Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update matchesAncestors to search light-dom ancestors #30

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Update matchesAncestors to search light-dom ancestors #30

merged 1 commit into from
Apr 11, 2024

Conversation

iandeboisblanc
Copy link

This PR addresses #29 by extending matchesAncestor helper to search through light-dom ancestors once it has reached the bounds of a shadow-dom.

Checklist

aearly
aearly reviewed Apr 9, 2024
View reviewed changes
Copy link

@aearly aearly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case to example/webcomponents.html?

@fabiancook
Copy link
Contributor

Merging as is, will follow up with adding a test case prior to versioning and release.

@fabiancook fabiancook merged commit 92864b6 into virtualstate:main Apr 11, 2024
5 checks passed
@fabiancook
Copy link
Contributor

Added in 9000b43

@iandeboisblanc iandeboisblanc deleted the shadow-dom-nav-event branch April 11, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aearly aearly aearly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iandeboisblanc @fabiancook @aearly